Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ism profile to OL9 #12346

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Add Ism profile to OL9 #12346

merged 4 commits into from
Aug 28, 2024

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Aug 27, 2024

Description:

  • Add ISM profile for OL9
  • Update ism_o control with rules already present in RHEL9

Rationale:

  • OL9 didn't have this profile

Xeicker added 3 commits August 27, 2024 12:57
@Xeicker
Create ism profile for OL9
a17c3e0 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Update ism control
93b1278 
Add 0484 id, and add file_permissions_sshd_private_key to 1449

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Update comments in OL9 ISM profile
8414c0a 
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested a review from a team as a code owner August 27, 2024 18:59
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.75 milestone Aug 27, 2024
@Mab879 Mab879 added Oracle Linux Oracle Linux product related. New Product Issues or pull requests related to new Products. labels Aug 27, 2024
@Mab879 Mab879 self-assigned this Aug 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12346
This image was built from commit: e5ad97d

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12346

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12346 make deploy-local

@Mab879 Mab879 added New Profile Issues or pull requests related to new Profiles. and removed New Product Issues or pull requests related to new Products. labels Aug 27, 2024
Mab879
Mab879 requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I just have one comment.

products/ol9/profiles/ism_o.profile Outdated Show resolved Hide resolved
@Xeicker @Mab879
Update OL9 ism_o profile comment
e5ad97d 
Co-authored-by: Matthew Burket <m@tthewburket.com>
@codeclimate CodeClimate
Copy link

codeclimate bot commented Aug 27, 2024

Code Climate has analyzed commit e5ad97d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879
Copy link
Member

Mab879 commented Aug 28, 2024

Overriding CODEOWNERS since @Xeicker cannot approve his own PRs.

@Mab879 Mab879 merged commit 77e614a into ComplianceAsCode:master Aug 28, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
New Profile Issues or pull requests related to new Profiles. Oracle Linux Oracle Linux product related.
Projects
None yet
Milestone
0.1.75
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeicker @Mab879