-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ANSSI BP28 profiles in rhel10 product #12351
Update ANSSI BP28 profiles in rhel10 product #12351
Conversation
Skipping CI for Draft Pull Request. |
@Mab879 @marcusburghardt as you worked with some profile in rhel10 product recently... could you voice your opinion on rules which I made no longer excluded from the ANSSI profile? It was not clear to me why they were actually excluded. Thank you. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
72f7648
to
1a48a62
Compare
Hello @Mab879 and thank you. Issues you highlighted were caused by copying over files from RHEL 9. I fixed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RHEL10 is using yescrypt
by default instead of SHA512. Could you update the variables, please?
It was also not clear to me the reason some the rules were excluded. But your updates make sense to me. You only need to ensure these rules have CCEs for RHEL 10. |
758c5e3
to
5686362
Compare
@vojtapolasek the CCEs errors are still present. |
@marcusburghardt I added missing CCEs.Hello @Mab879 and thank you. Issues you highlighted were caused by copying over files from RHEL 9. I fixed that. |
the old directive still works, buti it will be deprecated in the future
revise list of unselected rules add comments to better explain why a rule is excluded
it is root in RHEL 10
fcefd9a
to
b57dc24
Compare
The Ansible remediation does not work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My local tests worked fine testing the profile and remediating with Ansible. However, when remediating with Bash the automatus test finishes with error. I isolated the problem and it is related to the service_sssd_enabled
rule. I saw some issues with this rule and intend to fix them soon. But for now, could you also remove this rule from the RHEL 10 Draft profiles, please?
@vojtapolasek , I would recommend to remove the following rules from RHEL 10 profiles for now so we can merge this PR:
I am working on these rules in #12378 but it will still take some time to organize all these SSSD related rules. |
Code Climate has analyzed commit ebb1265 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @vojtapolasek . Thanks
5b1ef7c
into
ComplianceAsCode:master
Description:
Rationale:
Review Hints: