-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assertions for PCI-DSS profile #12362
Update assertions for PCI-DSS profile #12362
Conversation
/test |
@rhmdnd: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test 4.13-e2e-aws-ocp4-pci-dss-node |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
We recently updated the PCI-DSS profile to use 4.0 by default, but didn't update the default assertions. This commit updates the assertions so that the versionless profile name includes assertions for rules in the v4.0 profile.
eaecea1
to
95b59c6
Compare
/test 4.17-e2e-aws-ocp4-pci-dss |
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The 4.17 rules are failing because we didn't include the assertions after adding a handful of rules to 4.17 - #12311 |
We recently enabled these rules for 4.17, but didn't update the 4.17 PCI-DSS assertion files for them. This commit does that so that.
/test 4.17-e2e-aws-ocp4-pci-dss |
Code Climate has analyzed commit 640d221 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We recently updated the PCI-DSS profile to use 4.0 by default, but
didn't update the default assertions. This commit updates the assertions
so that the versionless profile name includes assertions for rules in
the v4.0 profile.