Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two CIS RHEL 9 enhancements #12453

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Two CIS RHEL 9 enhancements #12453

merged 2 commits into from
Oct 3, 2024

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • control 2.3.1 - switch the rule package_chrony_installed from related rules to rules
  • control 1.6.6 - add a note explaining why the control is manual

Rationale:

Review Hints:

  • build the content and check the profile contents. Eventually, run Automatus in profile mode.

@vojtapolasek
add one rule and a note to cis control file
5f67a12 
the rule package_chrony_installed was for some reason in related rules only
a note added to the control disabling certain cipher in sshd explains why the control is marked as manual
@vojtapolasek
modify profile stability data
19d3cff
@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Oct 2, 2024
@vojtapolasek vojtapolasek added this to the 0.1.75 milestone Oct 2, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner October 2, 2024 07:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

marcusburghardt
marcusburghardt approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt self-assigned this Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12453
This image was built from commit: 19d3cff

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12453

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12453 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit 19d3cff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@vojtapolasek
Copy link
Collaborator Author

/packit retest failed

@vojtapolasek
Copy link
Collaborator Author

/packit retest-failed

@Mab879 Mab879 merged commit 3efbf63 into ComplianceAsCode:master Oct 3, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

@Mab879 Mab879 Mab879 approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
bugfix Fixes to reported bugs. CIS CIS Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.75
Development

Successfully merging this pull request may close these issues.
3 participants
@vojtapolasek @Mab879 @marcusburghardt