Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package_rear_installed to related rules in e8 #12456

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 2, 2024

Description:

Move package_rear_installed to related rules in e8.

Rationale:

More configuration is needed for backups, the check should be manual.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Oct 2, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Oct 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12456
This image was built from commit: e15696b

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12456

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12456 make deploy-local

@vojtapolasek vojtapolasek self-assigned this Oct 3, 2024
@vojtapolasek
Copy link
Collaborator

@Mab879 I think the status of the control should be changed as well. Probably to manual. What do you think?

@Mab879
Copy link
Member Author

Mab879 commented Oct 4, 2024

@Mab879 I think the status of the control should be changed as well. Probably to manual. What do you think?

That makes sense. I will get a commit up shortly.

More is needed for backups, the check should be manual
Copy link

codeclimate bot commented Oct 4, 2024

Code Climate has analyzed commit e15696b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@vojtapolasek vojtapolasek merged commit 1a91080 into ComplianceAsCode:master Oct 7, 2024
100 checks passed
@Mab879 Mab879 deleted the remove_rear_rhel10 branch October 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants