Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL 10 to Jinja if statements in firewalld_sshd_port_enabled #12504

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 16, 2024

Description:

Add RHEL 10 to Jinja if statements in firewalld_sshd_port_enabled

Rationale:

Getting ready for RHEL 10.

@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 16, 2024
@Mab879 Mab879 added this to the 0.1.75 milestone Oct 16, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to extend also the condition in linux_os/guide/services/ssh/ssh_server/firewalld_sshd_port_enabled/rule.yml on line 58?

@jan-cerny jan-cerny self-assigned this Oct 17, 2024
@Mab879
Copy link
Member Author

Mab879 commented Oct 17, 2024

Do we need to extend also the condition in linux_os/guide/services/ssh/ssh_server/firewalld_sshd_port_enabled/rule.yml on line 58?

Updated. Thanks.

Copy link

codeclimate bot commented Oct 17, 2024

Code Climate has analyzed commit dd341d9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit 23aed2a into ComplianceAsCode:master Oct 18, 2024
103 of 104 checks passed
@Mab879 Mab879 deleted the fix_firewalld_sshd_port_enabled_rhel10 branch October 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants