Change platform in xwindows_runlevel_target #12563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
The rule xwindows_runlevel_target should be applicable during bootable container image build. The built image should contain a correct systemd default target because once the image is booted this target will be applied. Therefore we are extending the rule applicability also to bootable containers.
jan-cerny
force-pushed
the
runlevel_target
branch
from
aed3d91
to
b6e9610
Compare
|
I have rebased this PR on the top of the latest upstream master branch. |
|
Code Climate has analyzed commit b6e9610 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
matusmarhefka
approved these changes
Nov 4, 2024
matusmarhefka
merged commit ea5f884
into
ComplianceAsCode:master
104 of 105 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule xwindows_runlevel_target should be applicable during bootable container image build. The built image should contain a correct systemd default target because once the image is booted this target will be applied. Therefore we are extending the rule applicability also to bootable containers.