Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP: Added control resonse for NIST AU #8511

Merged
merged 1 commit into from
May 1, 2022

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Apr 7, 2022

Added control response for AU-9(3) AU-5(1) AU-5(2) AU-12(1) AU-12(3) AU-3(2)

Add rule:

alert_receiver_configured
cluster_logging_operator_exist

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
Platform #ocp4.8 not defined in platform specification
Platform #ocp4.8 not defined in platform specification
Platform #ocp4.6 not defined in platform specification
Platform #ocp4.6 not defined in platform specification

@Vincent056
Copy link
Contributor Author

/retest

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and questions inline, overall looking good.

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Vincent056 added a commit to ComplianceAsCode/compliance-operator that referenced this pull request Apr 28, 2022
We are going to have a new rule to check if cluster logging operator has been installed, that requires api-resource-collector to have additional permission to read clusterloggings resources.[1] PR to the new rule: ComplianceAsCode/content#8511
@Vincent056
Copy link
Contributor Author

/retest

@jan-cerny
Copy link
Collaborator

@Vincent056 please rebase
@jhrozek feel free to merge once it's rebased

Added control response for AU-9(3) AU-5(1) AU-5(2) AU-12(1) AU-12(3) AU-3(2)
@jhrozek
Copy link
Collaborator

jhrozek commented Apr 30, 2022

e2e:

    helpers.go:1028: Command '/go/src/github.com/ComplianceAsCode/content/applications/openshift/integrity/reject_unsigned_images_by_default/tests/ocp4/e2e-remediation.sh' timed out

which looks like a transient failure. The moderate suite didn't run because the cluster didn't install.

@jhrozek
Copy link
Collaborator

jhrozek commented Apr 30, 2022

/retest

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Vincent056 Vincent056 merged commit b1c66aa into ComplianceAsCode:master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants