-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRG Export XLSX in CMake #9811
SRG Export XLSX in CMake #9811
Conversation
bf93136
to
f7b748a
Compare
To make the script not output when used in things like the build system.
So that SRG diff creation process is taken from a four-step process to a two-step process.
f7b748a
to
6cfe5bc
Compare
Code Climate has analyzed commit 2a10bef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 47.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run the RHEL 9 build with the SSG_SRG_XSLX_EXPORT option turned on and I have found a generated XLSX export table.
/packit test |
/packit test |
The CI fail in Fedora rawhide is unrelated to this PR, it's caused by libxml2 ABI break, see https://bugzilla.redhat.com/show_bug.cgi?id=2139546 |
Description:
This PR adds the ability to create the XLSX files from
utils/create_srg_export
from the build system.Rationale:
This PR makes using the
utils/srg_diff.py
script much easier. Instead of running a four-step process (building, creating rule_dir_json, creating the SRG export, then creating the SRG Diff HTML report), this PR brings it to two steps (building the product and creating the SRG Diff HTML report).Review Hints:
ADDITIONAL_CMAKE_OPTIONS="-DSSG_SRG_XLSX_EXPORT=ON" ./build_product -j9 rhel9