solana-trie: add support for witness account #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
force-pushed
the
mpn/e
branch
3 times, most recently
from
c519bb9 to
6143565
Compare
dhruvja
approved these changes
Sep 5, 2024
To help with bytemuck use of CryptoHash, make it Copy, Pod and Zeroable. Most of the changes in this comit are made with `cargo clippy --fix`. The only manual part is addition of Copy, bytemuck::Pod and bytemuck::Zeroable derives to CryptoHash in common/lib/src/hash.rs.
Replace types::Hash type with lib::hash::CryptoHash. Turns out, lack of conversion between it and solana_program’s Hash types isn’t a big deal at all. And with CryptoHash now being bytemuck::Pod and Zeroable there’s no longer need for this custom type. Replace its uses with CryptoHash.
Witness of the trie is an account which stores the trie’s hash. Using Solana’s account delta hash this allows us to construct a proof of the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed individually on commit level. I intend to rebase it rather than squashing.