Version 6.6.3 #286
Merged
Version 6.6.3 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CRYPTONOTE_NAME has been changed to BLOCKCHAIN_DIR as the main reason this is used is to name the blockchain folder when the daemon is launched * CCX_RELEASE_VERSION + CCX_WALLET_RELEASE_VERSION additions to form a string saying "Conceal (or wallet) v" + version + (ID) * `print_genesis_tx_hex()` will now only print a random hash, the user who is using this command should know what to do with it, we're not here to teach * remove commented code * pretty daemon - remove timestamps and log level from client, keep them to the log file * removed `renameDataDir()` as I think this comes from the cryptonote era as as far as i know, conceal has never been called anything different * removed all previous calls of `std::cout` to respectively run whatever string through the logger * made use of 2 already implemented functions, `print_bci` and `print_bc_outs <file_name>` * made use of &args in every command by using it for usage checks * added debugging logging on commands (and functions in this file), maybe they'll prove useful *
* we use this function as a boolean, just in case in the future we ever do need to list all the block hashes. * updated daemon command to false on print blockchain indexs so it will print the id of the current height and not an array from 0 to current
I can't seem to figure a way for this command to print out only the information for a given height, I suggest we re-remove this command for now. This is a debug command to be fair and shouldn't really be needed by the user
* taken from the review of this opened pr. * EDIT: Added BUILD_COMMIT_ID as a debugging log next to version. * if we want a user who is maybe having trouble to produce the exact version, then loading the daemon with the version flag will produce the ID without the need to change the log level within the daemon to find it out
Accidental double ops “<<“
Matches BLOCKCHAIN_DIR[] original state
Daemon SonarCloud
Windows uses a Carriage Return (CR) followed by the Line Feed (LF) character, while Unix based operating systems use the Line Feed (LF) alone. This commit includes some standards for Git Line Endings and LFS.
Update .gitattributes
Update external dependencies
Fix reorganize crash
fix conceald --help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.