Banking features to concealwallet
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same logic as list_transfers
90s error, flashbacks
Return false instead of breaking Fix spelling
Ive been sus of tests for a while now, thinking one every X times during tests it fails
Im absolutly sure that `confirm_deposit()` works as intended This follows the same logic as the tests (TestWalletLegacy.cpp)
Maybe we should make this universal across Deposit and WalletLegacyTransaction
while(true) with a return true statement? Just to be on the safe side
Old output used to have a header to list each detail, now the output will list:
```
--- Deposit Info ---
ID: <deposit_id>
Amount: <amount>
Interest: <interest>
Term: <term>
Status: <is_locked_bool>
Unlock Height: <unlock_height>
```
deposit details will either be `BRIGHT_RED` if locked or `BRIGHT_GREEN` if unlocked
Works on my machine
Fixes calling `cn::Deposit::unlockHeight` + `cn::Deposit::height`
* adds new file DepositHelper to feed infomation * adds get_deposit(id) to iwalletlegacy so we can call deposit = get_deposit(id) * add height and unlockheight to legacydeposit * add notes to previous work
Adds saveDeposits and loadDeposits to wallet serializer. This copies wallet serializer v2 with slight modifications
This was apart of testing during the PR and it's safe to say we don't need this.
* removes unused function from namespace
With the new changes, the height would only of been imported from `concealwallet`s deposit request. This keeps support for the GUI, `if t_height == 0` it hasn't came from simplewallet
* this was suggested by Ax, it seems to work as an alternative serialise new data * also removes table format from balance
* this was taken from Ax's suggestion within the discord * makes use of `splitUrlToHostAndUri()`
Reverted back to original state
Banking features to `concealwallet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.