Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross Markdown Engine working Tags #65

Closed
thmarx opened this issue Nov 9, 2023 · 1 comment · Fixed by #67
Closed

Cross Markdown Engine working Tags #65

thmarx opened this issue Nov 9, 2023 · 1 comment · Fixed by #67
Milestone
2.6.0

Comments

@thmarx
Copy link
Collaborator

thmarx commented Nov 9, 2023

Writing an extension for all supported MarkdownEngines would be a lot of work and completely out of scope.
So we should introduce some kind of tags that are parsed before or after markdown rendering and replaced with html code.

example

[[youtube id="video-id"]]
@thmarx thmarx added this to the 2.6.0 milestone Nov 9, 2023
thmarx pushed a commit that referenced this issue Nov 9, 2023
#65 simple [[tag]] system to extend content
bc32c8b
thmarx pushed a commit that referenced this issue Nov 9, 2023
#65 code cleanup, legacy code removed
c17e157
thmarx pushed a commit that referenced this issue Nov 9, 2023
#65 extend content tags for open and close tags
84f0e44 
[[tag]]Hello people.[[/tag]]
short version is also possible
[[tag /]]
@thmarx
Copy link
Collaborator Author

thmarx commented Nov 9, 2023

Support for long and short tags added

long version: [[tag]]Some content[[/tag]]
short version: [[tag /]]

thmarx pushed a commit that referenced this issue Nov 9, 2023
#65 add test for long tag with parameters
d68e694
thmarx pushed a commit that referenced this issue Nov 10, 2023
#65 add test
7b13aac
@thmarx thmarx linked a pull request Nov 10, 2023 that will close this issue
65 cross markdown engine working tags #67
Merged
thmarx added a commit that referenced this issue Nov 10, 2023
@thmarx
65 cross markdown engine working tags (#67)
343d4cc 
* #65 simple [[tag]] system to extend content

* #65 code cleanup, legacy code removed

* #65 extend content tags for open and close tags
[[tag]]Hello people.[[/tag]]
short version is also possible
[[tag /]]

* #65 add test for long tag with parameters

* #65 add test

---------

Co-authored-by: Thorsten Marx <t.marx@eggheads.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

65 cross markdown engine working tags CondationCMS/cms-server
1 participant
@thmarx