Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dom): increase code coverage for input, textarea, and doctype nodes #25

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

pgoldrbx
Copy link

Description

  • expand test coverage for less common scenarios
  • add tests for when input values are set at runtime rather than by initial attribute
  • include tests for doctype node

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore, documentation, cleanup

Related Issue

Motivation and Context

This is work to help unblocking the jsdom upgrade by improving overall test coverage #20
There is nothing so far in these tests that gives me any concern about updating jsdom

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 95

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.9%) to 69.633%

Totals Coverage Status
Change from base Build 90: 4.9%
Covered Lines: 287
Relevant Lines: 375

💛 - Coveralls

Copy link

@neilius neilius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pgoldrbx pgoldrbx merged commit d29ffa3 into master Feb 24, 2020
@pgoldrbx pgoldrbx deleted the test/dom branch February 24, 2020 21:30
@pgoldrbx pgoldrbx mentioned this pull request Feb 25, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants