Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): export interface namespaces in addition to merged methods #36

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

pgoldrbx
Copy link

Description

Currently all methods are being merged into the top-level export from the module. It would be really helpful to export the individual namespaces. The existing documentation already implies this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore, documentation, cleanup

Related Issue

Motivation and Context

  • the docs and source are out of sync
  • the distributed package could be a bit difficult to use, given so many methods and only needing a subset

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pgoldrbx pgoldrbx requested a review from neilius April 14, 2020 21:54
@pgoldrbx pgoldrbx added the enhancement New feature or request label Apr 14, 2020
html,
utils,
xml
);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current babel configuration doesn't allow for namespaces, ...namespaces just yet

@coveralls
Copy link

Pull Request Test Coverage Report for Build 149

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.453%

Totals Coverage Status
Change from base Build 148: 0.02%
Covered Lines: 476
Relevant Lines: 532

💛 - Coveralls

@pgoldrbx pgoldrbx merged commit 53f7d03 into master Apr 14, 2020
@pgoldrbx pgoldrbx deleted the fix/namespaces branch April 14, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants