-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing support via OpenTelemetry #254
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 84 files out of 270 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
A lot of the tracers are prefixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small questions, spans look good though
Just FYI I rebased this and fixed conflicts. Hopefully I didn't mess anything up. |
Adds tracing support. SDK instruments the root process, and propagates trace context to the child process. The connector implementation can trace functions as well. grpc calls are traced automatically.
The root process will be named after the connector, e.g.
baton-github
. The child process service name will have-server
appended to the service name.This also adds a open telemetry stack via docker-compose. This runs an otel collector, prometheus, loki, tempo, and grafana. Currently only tracing is implemented, so prometheus and loki are going unused, but it won't be difficult to add support for those.
TODO