Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support TLS without authentication #118

Merged
merged 4 commits into from
Jan 19, 2024
Merged

support TLS without authentication #118

merged 4 commits into from
Jan 19, 2024

Conversation

samirketema
Copy link
Contributor

Description

  • Adds the ability to use TLS without authentication via certificates
  • Fixes the dialer to use the opts from the provided configuration (including TLS)

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@samirketema samirketema requested a review from a team as a code owner January 19, 2024 01:11
@samirketema samirketema changed the title add TLS without authentication support TLS without authentication Jan 19, 2024
maha-hajja
maha-hajja approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

common/tls.go Outdated Show resolved Hide resolved
@samirketema samirketema merged commit 1b20004 into main Jan 19, 2024
3 checks passed
@samirketema samirketema deleted the samir/add-unauthenticated-tls branch January 19, 2024 16:17
@samirketema samirketema mentioned this pull request Jan 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja approved these changes

@hariso hariso Awaiting requested review from hariso

@lovromazgon lovromazgon Awaiting requested review from lovromazgon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samirketema @maha-hajja