-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support reading from multiple tables using logical replication slots #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there's a few followups we need to do, as you already pointed out in comments. I'll collect them here:
- update the snapshot iterator to fetch data from multiple tables
- remove
key
andcolumn
config fields - think about actually having a
key
field that accepts comma separatedtable:column
pairs - later on introduce a Conduit-wide convention for specifying the source table/topic/collection that can be used for routing in destination connectors and add the metadata field instead of (or in addition to?) the
postgres.table
metadata field
I think at least the first three would be needed to make this feature complete so we can cut a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing.
Description
support reading from multiple tables using logical replication slots.
changes to params:
Fixes #23
Quick checks: