Skip to content

Commit

Permalink
Merge pull request #9 from Conflux-Chain/dev
Browse files Browse the repository at this point in the history
  • Loading branch information
yqrashawn authored Jul 2, 2020
2 parents ead4b73 + b31992f commit c0df0b0
Show file tree
Hide file tree
Showing 28 changed files with 3,535 additions and 210 deletions.
38 changes: 31 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
version: 2
version: 2.1
workflows:
build_test_release:
jobs:
- test
- build
- release:
requires:
- build
- test
filters:
branches:
only: /^master|dev|alpha|[0-9]+\.[0-9]+\.x$/

jobs:
test:
docker:
Expand Down Expand Up @@ -47,9 +60,20 @@ jobs:
key: v2-dependencies-{{ checksum "package.json" }}

- run: yarn run build
workflows:
version: 2
build_and_test:
jobs:
- test
- build
- persist_to_workspace:
root: .
paths:
- dist
- esm

release:
docker:
- image: circleci/node:12.0

working_directory: ~/repo

steps:
- checkout
- attach_workspace:
at: .
- run: npx semantic-release
8 changes: 6 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,15 @@ At any time, you think it's ok, you can start the following steps to submit your

### Q & A

> I added a new document page, but it was not displayed locally?
> How to choose the target branch of PR ?
- If this is a `feature`, set to `rc` branch. All the others are set to `master` branch.

> I added a new document page, but it was not displayed locally ?
- Run `yarn dev` agian.

> How can I update remote origin?
> How can I update remote origin ?
- refer to [here](https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes).

Expand Down
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/1-bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,25 @@ name: "Bug report 🐞"
about: "If something isn't working as expected 🤔."
---

<!-- Please do NOT DELETE the template. -->
<!-- No template issues will be closed. -->

# Bug report 🐞

## Version & Environment

- Version of browser
- Version of `zeit-ui/react`

## Expection

The behavior I expect is ...

## Actual results (or Errors)

I got an error:

```
code
```

20 changes: 12 additions & 8 deletions .github/ISSUE_TEMPLATE/2-feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,23 @@ name: "Feature request 🚀"
about: "I have a suggestion!"
---

# Feature request 🚀
<!-- Please do NOT DELETE the template. -->
<!-- No template issues will be closed. -->

### Expected:
- No breaking changes
# Feature request 🚀

### Examples:
```js
```
- [ ] I will create Pull Request
- [x] It's just a suggestion

### Programme:
### Expected

### Others:
- Component or something else

### Examples

```jsx
```

### Programme (Optional)

### Others (Optional)
22 changes: 22 additions & 0 deletions .github/ISSUE_TEMPLATE/3-docs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: "About `docs` 🛠️"
about: "Issues and feature requests for docs"
---

<!-- Please do NOT DELETE the template. -->
<!-- No template issues will be closed. -->

# About `docs`

This is a document site related issue.

### Languages

- [x] English
- [ ] Chinese

### Description


### Page Links (Optional)

8 changes: 0 additions & 8 deletions .github/ISSUE_TEMPLATE/3-styles.md

This file was deleted.

7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/4-docs.md

This file was deleted.

4 changes: 1 addition & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
## PR Checklist
## Checklist

- [ ] Fix linting errors
- [ ] Label has been added


## Change information


32 changes: 32 additions & 0 deletions .github/semantic.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Always validate the PR title, and ignore the commits
titleOnly: false

# Always validate all commits, and ignore the PR title
commitsOnly: false

# Always validate the PR title AND all the commits
titleAndCommits: true

# By default types specified in commitizen/conventional-commit-types is used.
# See: https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json
# You can override the valid types
types:
- feat
- fix
- docs
- style
- refactor
- perf
- test
- build
- ci
- chore
- revert

# Allow use of Merge commits (eg on github: "Merge branch 'master' into feature/ride-unicorns")
# this is only relevant when using commitsOnly: true (or titleAndCommits: true)
allowMergeCommits: true

# Allow use of Revert commits (eg on github: "Revert "feat: ride unicorns"")
# this is only relevant when using commitsOnly: true (or titleAndCommits: true)
allowRevertCommits: true
12 changes: 12 additions & 0 deletions .jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ module.exports = {
'!components/utils/*',
],

// https://jestjs.io/docs/en/configuration#coveragethreshold-object
coverageThreshold: {
global: {
// meaning of each coverage
// https://www.guru99.com/code-coverage.html
branches: 96.1,
functions: 99.15,
lines: 100,
statements: 98.78,
},
},

moduleNameMapper: {
'tests/(.*)$': '<rootDir>/tests/$1',
components: '<rootDir>/components/index.ts',
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node
17 changes: 15 additions & 2 deletions components/auto-complete/auto-complete-item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Ellipsis from '../shared/ellipsis'

interface Props {
value: string
isLabelOnly?: boolean
}

const defaultProps = {}
Expand All @@ -26,6 +27,7 @@ const getSizes = (size: NormalSizes) => {
const AutoCompleteItem: React.FC<React.PropsWithChildren<AutoCompleteItemProps>> = ({
value: identValue,
children,
isLabelOnly,
}) => {
const theme = useTheme()
const { value, updateValue, size, updateVisible } = useAutoCompleteContext()
Expand All @@ -37,9 +39,20 @@ const AutoCompleteItem: React.FC<React.PropsWithChildren<AutoCompleteItemProps>>
const isActive = useMemo(() => value === identValue, [identValue, value])
const fontSize = useMemo(() => getSizes(size), [size])

// The 'isLabelOnly' is only used inside the component,
// Automatically adjust width when only label children is included.
const itemHeight = useMemo(() => {
if (isLabelOnly) return `calc(1.688 * ${theme.layout.gap})`
return 'auto'
}, [isLabelOnly, theme.layout.gap])

return (
<div className={`item ${isActive ? 'active' : ''}`} onClick={selectHandler}>
<Ellipsis height={`calc(1.688 * ${theme.layout.gap})`}>{children}</Ellipsis>
{isLabelOnly ? (
<Ellipsis height={`calc(1.688 * ${theme.layout.gap})`}>{children}</Ellipsis>
) : (
children
)}
<style jsx>{`
.item {
display: flex;
Expand All @@ -49,7 +62,7 @@ const AutoCompleteItem: React.FC<React.PropsWithChildren<AutoCompleteItemProps>>
white-space: pre;
font-size: ${fontSize};
padding: 0 ${theme.layout.gapHalf};
height: calc(1.688 * ${theme.layout.gap});
height: ${itemHeight};
background-color: ${theme.palette.background};
color: ${theme.palette.foreground};
user-select: none;
Expand Down
2 changes: 1 addition & 1 deletion components/auto-complete/auto-complete.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const childrenToOptionsNode = (options: Array<AutoCompleteOption>) =>
if (React.isValidElement(item)) return React.cloneElement(item, { key })
const validItem = item as AutoCompleteOption
return (
<AutoCompleteItem key={key} value={validItem.value}>
<AutoCompleteItem key={key} value={validItem.value} isLabelOnly>
{validItem.label}
</AutoCompleteItem>
)
Expand Down
2 changes: 1 addition & 1 deletion components/user/__tests__/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe(' User', () => {

it('should pass alt attribute', () => {
const wrapper = mount(
<User name="witt" src="https://unix.bio/assets/avatar.png" altText="witt"/>
<User name="witt" src="https://unix.bio/assets/avatar.png" altText="witt" />,
)
expect(wrapper.find('img').prop('alt')).toEqual('witt')
})
Expand Down
6 changes: 3 additions & 3 deletions examples/create-next-app/pages/_app.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { ZeitProvider, CssBaseline } from '@zeit-ui/react';
import { ZeitProvider, CssBaseline } from '@zeit-ui/react'

function MyApp({ Component, pageProps }) {
return (
<ZeitProvider>
<CssBaseline />
<Component {...pageProps} />
</ZeitProvider>
);
)
}
export default MyApp;
export default MyApp
19 changes: 7 additions & 12 deletions examples/create-next-app/pages/_document.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
import Document, {
Html,
Head,
Main,
NextScript,
} from 'next/document';
import { CssBaseline } from '@zeit-ui/react';
import Document, { Html, Head, Main, NextScript } from 'next/document'
import { CssBaseline } from '@zeit-ui/react'

class MyDocument extends Document {
static async getInitialProps(ctx) {
const initialProps = await Document.getInitialProps(ctx);
const styles = CssBaseline.flush();
const initialProps = await Document.getInitialProps(ctx)
const styles = CssBaseline.flush()

return {
...initialProps,
Expand All @@ -19,7 +14,7 @@ class MyDocument extends Document {
{styles}
</>
),
};
}
}

render() {
Expand All @@ -31,8 +26,8 @@ class MyDocument extends Document {
<NextScript />
</body>
</Html>
);
)
}
}

export default MyDocument;
export default MyDocument
20 changes: 10 additions & 10 deletions examples/create-next-app/pages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@ export default function Home() {
<title>Create Next App</title>
<link rel="icon" href="/favicon.ico" />
</Head>
<Text h1>
Welcome to <a href="https://nextjs.org">Next.js!</a>
</Text>
<Card>
hello, world. I am using <Code>@zeit-ui/react</Code> !
</Card>
<Spacer y={1.5} />
<Card shadow>
<Note type="success">This note details something important.</Note>
</Card>
<Text h1>
Welcome to <a href="https://nextjs.org">Next.js!</a>
</Text>
<Card>
hello, world. I am using <Code>@zeit-ui/react</Code> !
</Card>
<Spacer y={1.5} />
<Card shadow>
<Note type="success">This note details something important.</Note>
</Card>
</Page>
)
}
12 changes: 6 additions & 6 deletions examples/tree-shaking-create-react-app/config-overrides.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { override, fixBabelImports } = require('customize-cra');
module.exports = override(
fixBabelImports('@zeit-ui/react', {
libraryDirectory: 'esm',
}),
);
const { override, fixBabelImports } = require('customize-cra')
module.exports = override(
fixBabelImports('@zeit-ui/react', {
libraryDirectory: 'esm',
}),
)
4 changes: 1 addition & 3 deletions examples/tree-shaking-nextjs/.babelrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"presets": [
"next/babel"
],
"presets": ["next/babel"],
"plugins": [
[
"import",
Expand Down
Loading

0 comments on commit c0df0b0

Please sign in to comment.