Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add semantic-release #6

Merged
merged 1 commit into from
Jun 29, 2020
Merged

ci: add semantic-release #6

merged 1 commit into from
Jun 29, 2020

Conversation

yqrashawn
Copy link

@yqrashawn yqrashawn commented Jun 29, 2020

use https://github.com/semantic-release/semantic-release workflow

the mechanism of semantic-release is complicate, the docs can be found at https://github.com/semantic-release/semantic-release/blob/master/docs/usage/README.md

  1. its configuration is in the release field of package.json file
  2. the default release rule (which kind of commit type leads to which kind of release (major, minor, patch)) is the Angular one at https://github.com/semantic-release/commit-analyzer/blob/master/lib/default-release-rules.js
  3. code in dev branch will be released into the @beta chanel (user can install it with yarn add @conflux-ui/react@beta)
  4. code in master branch will be released into the @latest chanel (user can install it with yarn add @conflux-ui/react)
  5. the workflow is
    1. push code into feature branch, PR to dev branch
    2. PR got merged into dev branch, release to npm @beta channel, the version number will be x.x.x-beta.x
    3. PR from dev to master, release to npm @latest channel (default channel)
  6. no need to back-merge, say, master back to dev

This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #6 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev       #6   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         186      186           
  Lines        2366     2366           
  Branches      563      563           
=======================================
  Hits         2365     2365           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9abc23...9f6f941. Read the comment docs.

package.json Outdated
@@ -1,13 +1,13 @@
{
"name": "@conflux/react-ui",
"version": "0.0.1",
"name": "@conflux-ui/react",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change name from react-ui to react?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause there's @conflux-ui as the org name, @conflux-ui/react-ui is a bit noisy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants