Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): set the pageSize value to default value of dropdown … #95

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

zctocm
Copy link

@zctocm zctocm commented Sep 15, 2020

When setting the pageSize prop, the default value of the dropdown list of Select should be the
default pageSize value

fix #94

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

…list

When setting the pageSize prop, the default value of the dropdown list of Select should be the
default pageSize value

fix #94
@zctocm zctocm added the bug Something isn't working label Sep 15, 2020
@zctocm zctocm self-assigned this Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #95 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          201       201           
  Lines         2835      2838    +3     
  Branches       741       708   -33     
=========================================
+ Hits          2835      2838    +3     
Impacted Files Coverage Δ
components/pagination/pagination-pageSize.tsx 100.00% <100.00%> (ø)
components/pagination/pagination.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4529e4...f9ebb56. Read the comment docs.

@zctocm zctocm linked an issue Sep 15, 2020 that may be closed by this pull request
@zctocm zctocm merged commit 09248a8 into dev Sep 15, 2020
@zctocm zctocm deleted the pagination-fix branch September 15, 2020 03:38
@ConfluxBot
Copy link

🎉 This PR is included in version 1.0.0-alpha.52 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ConfluxBot
Copy link

🎉 This PR is included in version 2.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ConfluxBot
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Pagination)the default value of pageSizeOptions has not changed
4 participants