Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromecast: After playing audio/video, tap on "Stop" tab should disable Play/Pause/Close tabs. #86

Closed
Vijeyta opened this issue Jun 3, 2014 · 6 comments
Closed

Chromecast: After playing audio/video, tap on "Stop" tab should disable Play/Pause/Close tabs. #86

Vijeyta opened this issue Jun 3, 2014 · 6 comments
Assignees
@Vijeyta
Labels
sampler
Milestone
v1.3.2

Comments

@Vijeyta
Copy link

Vijeyta commented Jun 3, 2014

Tested on:
webOS TV Build: 605
Sampler app version: (v1.3.0.2)

Play audio/video>>tap on "Stop" tab>>Play/Pause/Close tabs should be disabled.
@iheart2code iheart2code added the bug label Jun 3, 2014
@iheart2code iheart2code added this to the v1.3 Final milestone Jun 3, 2014
@khk624 khk624 added sampler and removed bug labels Jun 4, 2014
@khk624
Copy link
Contributor

khk624 commented Jun 4, 2014

I think we did this on purpose. If we disabled "Play", "Pause" and "Close" when we tap on "Stop", then "Stop" will have no difference with "Close".

and this is sampler issue.

@henrylevak what do you think of this?
FYI, iOS sampler disabled Play, Pause, and Close buttons.

@henrylevak
Copy link
Contributor

this is a sampler bug. When pressing stop, we should disable play/pause/rewind/ffd buttons - moving this to 1.4

@henrylevak henrylevak modified the milestones: v1.4, v1.3 Final Jun 4, 2014
@henrylevak
Copy link
Contributor

close should not be disabled

khk624 pushed a commit to ConnectSDK/Connect-SDK-Android-API-Sampler that referenced this issue Jul 15, 2014
Fixed Chromecast: After playing audio/video, tap on "Stop" tab should…
a409f6f 
… disable Play/Pause/Stop tabs.

Fixed ConnectSDK/Connect-SDK-Android#86
@khk624
Copy link
Contributor

khk624 commented Jul 15, 2014

This has been resolved in ConnectSDK/Connect-SDK-Android-API-Sampler@a409f6f

@khk624 khk624 assigned Vijeyta and unassigned khk624 Jul 15, 2014
@Vijeyta
Copy link
Author

Vijeyta commented Jul 15, 2014

I need latest sampler build for Android for verifying & closing this issue.

@Vijeyta
Copy link
Author

Vijeyta commented Jul 16, 2014

Re-tested on:
Latest Android sampler app, issue is not reproducible, tapping on Stop tab disable Play/Pause & Close tab is enabled. Closing this issue.

On iOS device, Close tab is also disabled.

@Vijeyta Vijeyta closed this as completed Jul 16, 2014
@Vijeyta Vijeyta mentioned this issue Aug 5, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vijeyta Vijeyta

Labels
sampler
Projects
None yet
Milestone
v1.3.2
Development

No branches or pull requests
4 participants
@henrylevak @iheart2code @khk624 @Vijeyta