turn off cache busting #14
Conversation
Update from upstream repo facebookincubator/create-react-app
Update from upstream repo facebookincubator/create-react-app
Modify prod build Move package over to @connected-home Downgrade jest and babel-jest to support V3 Undo commented template section. Should work now that were referencing react-scripts as part of CRA rather than a folder in our project Delete yarn.lock file and use npm for this proj instead Remove fs package that was added by us for some reason Add HivehomeWebappFaviconsWebpackPlugin with proper config Remove path package from devDependencies
Adjust a few bits so that Jest works properly with V3 Add property to jest config for matching jest files in this lower version of jest
…the end Bump favicon plugin ref to 2.0.0 Change favicon config to use ios rather than iphone key Bump versions
all our existing stuff uses sha256 to - reduce chance of collisions - make the content more properly content-addressable
…react-app into facebookincubator-master
…v and prod. Added browser-detect to template paths. Exit early in locales when no directory path specified (template)
…ign with V3 requirements but this breaks e2e
Added items to the template to match the webpack build process for de…
Add build number to webpack env vars
Reset babel-jest and jest versions to match upstream
…react-app into facebookincubator-master
we do the "right thing" when settings headers on S3+CF https://github.com/GoogleChrome/sw-precache#dontcachebusturlsmatching-regex
| @@ -375,7 +375,7 @@ module.exports = { | |||
| // used to populate the caches, to ensure the responses are fresh. | |||
| // If a URL is already hashed by Webpack, then there is no concern | |||
| // about it being stale, and the cache-busting can be skipped. | |||
| dontCacheBustUrlsMatching: /\.\w{64}\./, | |||
| dontCacheBustUrlsMatching: /./, | |||
There was a problem hiding this comment.
Nice! Do we need this property at all?
There was a problem hiding this comment.
yes, without it defaults to cache busting everything.
There was a problem hiding this comment.
I'm not 100% sure on this one. Why is this a problem for us and not for any other CRA app?
There was a problem hiding this comment.
CRA defaults assume that people don't have the correct (or any) set cache-control (and related) headers properly on the web server where the static content comes from.
In those cases the cache busting is the "safe option" for making sure that fresh content always gets the browsers at the cost nothing being cached.
We have the correct headers set, and therefore can turn off the cache busting so that browser (and intermediate server) caches are used.
There was a problem hiding this comment.
actually to be more correct it's SWPrecacheWebpackPlugin that assumes people's cache headers are all wrong.
CRA itself does shorter version of hashing like we do for the static assets, and sets this value to /\.\w{8}\./ which basically turns off cache busting for the static assets (because if those assets change, so does their name and therefore no risk of the them being in a cache.)
JamieDixon
force-pushed
the
master
branch
4 times, most recently
from
05cea1a
to
e5d86e4
Compare
JamieDixon
force-pushed
the
master
branch
2 times, most recently
from
0b1821a
to
3eb48a0
Compare
JamieDixon
force-pushed
the
master
branch
3 times, most recently
from
adce63c
to
18a1ef6
Compare
JamieDixon
force-pushed
the
master
branch
2 times, most recently
from
99c27d1
to
8db9d8b
Compare
JamieDixon
force-pushed
the
master
branch
2 times, most recently
from
07b8bfe
to
5d5baee
Compare
No description provided.