Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quorum-board#197: add qlight token manager plugin #224

Conversation

baptiste-b-pegasys
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Add the documentation for the QLight token management: https://github.com/ConsenSys/quorum-board/issues/197

Issue fixed

https://github.com/ConsenSys/quorum-board/issues/197

Add "fixes #{your issue number}" to close the issue automatically when the PR is merged.

If your PR doesn't completely fix the issue, add "see #{your issue number}" to link to the issue
without automatically closing it. -->

Impacted parts

For content changes:

  • Documentation content: qlight node
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@baptiste-b-pegasys baptiste-b-pegasys requested a review from a team as a code owner May 12, 2022 12:11
@baptiste-b-pegasys baptiste-b-pegasys self-assigned this May 12, 2022
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview May 12, 2022 12:11 Inactive
@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview May 12, 2022 12:23 Inactive
@rolandtyler rolandtyler self-assigned this May 12, 2022
@rolandtyler rolandtyler temporarily deployed to preview May 16, 2022 13:47 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylistic edits and fixed link. LGTM now.

@rolandtyler rolandtyler merged commit f49d63c into Consensys:main May 16, 2022
@rolandtyler rolandtyler temporarily deployed to no-secret May 16, 2022 13:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants