Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify adding nodes in Raft #226

Merged
merged 4 commits into from
May 24, 2022
Merged

Conversation

rolandtyler
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Clarified how to add nodes in a raft network.

Issue fixed

Fixes #225

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@rolandtyler rolandtyler requested a review from a team as a code owner May 17, 2022 18:35
@rolandtyler rolandtyler temporarily deployed to preview May 17, 2022 18:35 Inactive
@NicolasMassart NicolasMassart temporarily deployed to preview May 23, 2022 11:50 Inactive
Co-authored-by: baptiste-b-pegasys <85155432+baptiste-b-pegasys@users.noreply.github.com>
@rolandtyler rolandtyler temporarily deployed to preview May 23, 2022 13:15 Inactive
@rolandtyler rolandtyler temporarily deployed to preview May 23, 2022 13:19 Inactive
@rolandtyler rolandtyler merged commit ca6bdad into Consensys:main May 24, 2022
@rolandtyler rolandtyler temporarily deployed to no-secret May 24, 2022 12:53 Inactive
@rolandtyler rolandtyler deleted the clarify-raft branch May 24, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing some raft.addPeer step when adding more raft node and filling the ID as raftjoinexisting argument
3 participants