Merge pull request #487 from Consensys/perf/IsOnCurve

perf: optimize curve membership test
Consensys · Feb 13, 2024 · 5a54be6 · 5a54be6
2 parents 2e4aaaa + cfbb52b
commit 5a54be6
Show file tree

Hide file tree

Showing 22 changed files with 113 additions and 123 deletions.
diff --git a/ecc/bls12-377/g1.go b/ecc/bls12-377/g1.go
diff --git a/ecc/bls12-377/g2.go b/ecc/bls12-377/g2.go
diff --git a/ecc/bls12-378/g1.go b/ecc/bls12-378/g1.go
diff --git a/ecc/bls12-378/g2.go b/ecc/bls12-378/g2.go
diff --git a/ecc/bls12-381/g1.go b/ecc/bls12-381/g1.go
diff --git a/ecc/bls12-381/g2.go b/ecc/bls12-381/g2.go
diff --git a/ecc/bls24-315/g1.go b/ecc/bls24-315/g1.go
diff --git a/ecc/bls24-315/g2.go b/ecc/bls24-315/g2.go
diff --git a/ecc/bls24-317/g1.go b/ecc/bls24-317/g1.go
diff --git a/ecc/bls24-317/g2.go b/ecc/bls24-317/g2.go
diff --git a/ecc/bn254/g1.go b/ecc/bn254/g1.go
diff --git a/ecc/bn254/g2.go b/ecc/bn254/g2.go
diff --git a/ecc/bw6-633/g1.go b/ecc/bw6-633/g1.go
diff --git a/ecc/bw6-633/g2.go b/ecc/bw6-633/g2.go
diff --git a/ecc/bw6-633/pairing.go b/ecc/bw6-633/pairing.go
@@ -320,7 +320,7 @@ func (p *g2Proj) doubleStep(evaluations *lineEvaluation) {
 	C.Square(&p.z)
 	D.Double(&C).
 		Add(&D, &C)
-	E.Mul(&D, &bTwistCurveCoeff)
+	E.Double(&D).Double(&E).Double(&E)
 	F.Double(&E).
 		Add(&F, &E)
 	G.Add(&B, &F)

diff --git a/ecc/bw6-756/g1.go b/ecc/bw6-756/g1.go
diff --git a/ecc/bw6-756/g2.go b/ecc/bw6-756/g2.go
diff --git a/ecc/bw6-761/g1.go b/ecc/bw6-761/g1.go
diff --git a/ecc/bw6-761/g2.go b/ecc/bw6-761/g2.go
diff --git a/ecc/bw6-761/pairing.go b/ecc/bw6-761/pairing.go
@@ -284,7 +284,7 @@ func (p *g2Proj) doubleStep(evaluations *lineEvaluation) {
 	C.Square(&p.z)
 	D.Double(&C).
 		Add(&D, &C)
-	E.Mul(&D, &bTwistCurveCoeff)
+	E.Double(&D).Double(&E)
 	F.Double(&E).
 		Add(&F, &E)
 	G.Add(&B, &F)

diff --git a/ecc/secp256k1/g1.go b/ecc/secp256k1/g1.go