Code

Improvement/field inv pornin20#106

Code

Merged

gbotrel merged 71 commits intodevelopConsensys/gnark-crypto:developfrom improvement/field-inv-pornin20Consensys/gnark-crypto:improvement/field-inv-pornin20Copy head branch name to clipboardDec 9, 2021

+13,792-1,928

Commits

Commits on Oct 28, 2021

• Ignore .DS_Store

  Tabaie

  committed
  c9c01b9

  Copy full SHA for c9c01b9

• Ignore Goland project files

  Tabaie

  committed
  8bb3662

  Copy full SHA for 8bb3662

Commits on Oct 29, 2021

• feat: Naive GCD works

  Tabaie

  committed
  6070316

  Copy full SHA for 6070316

• feat: Naive GCD improved

  Tabaie

  committed
  b611212

  Copy full SHA for b611212

Commits on Nov 1, 2021

• perf: Field element - Word multiplication implemented

  Tabaie

  committed
  772377a

  Copy full SHA for 772377a

Commits on Nov 2, 2021

• perf: Field element - Word multiplication implemented

  Tabaie

  committed
  175d545

  Copy full SHA for 175d545

Commits on Nov 4, 2021

• feat: Full paper implemented, unknown bug

  Tabaie

  committed
  0583abc

  Copy full SHA for 0583abc

Commits on Nov 5, 2021

• feat: Full paper implemented, tests passing

  Tabaie

  committed
  280751c

  Copy full SHA for 280751c

Commits on Nov 8, 2021

• feat: Test for corrective factor consistency

  Tabaie

  committed
  95f6292

  Copy full SHA for 95f6292

• perf: Batch each 2 u,v updates. Update factors correct result incorrect

  Tabaie

  committed
  1d85105

  Copy full SHA for 1d85105

• test: Consistency check on top

  Tabaie

  committed
  e245c06

  Copy full SHA for e245c06

Commits on Nov 9, 2021

• fix: Optimization 3 works, but with many watches

  Tabaie

  committed
  488a908

  Copy full SHA for 488a908

• fix: Optimization 3 works, removed debugging code, down to 1879 ns/op

  Tabaie

  committed
  bd597e3

  Copy full SHA for bd597e3

• fix: Non-const t: Precomputation gives little speedup: 1511,1463,1551

  Tabaie

  committed
  f1fba7b

  Copy full SHA for f1fba7b

• style: Some commentary

  Tabaie

  committed
  a04c917

  Copy full SHA for a04c917

• style: Some more commentary

  Tabaie

  committed
  11ceb6b

  Copy full SHA for 11ceb6b

• perf: field inverse optimizations

  gbotrel

  committed
  a56e55e

  Copy full SHA for a56e55e

Commits on Nov 10, 2021

• perf!: Towards 1 mont-red per u,v update instead of 2. mulModR dev'd

  Tabaie

  committed
  536a347

  Copy full SHA for 536a347

Commits on Nov 17, 2021

• perf: Linear comb w 1 MontRed instead of 2. Slow (debug logic inline)

  Tabaie

  committed
  a0cafca

  Copy full SHA for a0cafca

• perf: Removed debug logic

  Tabaie

  committed
  6a4cd29

  Copy full SHA for 6a4cd29

• refactor: SOS Montgomery Reduction

  Tabaie

  committed
  5ed39c5

  Copy full SHA for 5ed39c5

• perf: Branch-free signed non-mont word multiplication

  Tabaie

  committed
  c746ab4

  Copy full SHA for c746ab4

Commits on Nov 18, 2021

• style: Hand-inlined rsh31, comments, single correction factor

  Tabaie

  committed
  f218a38

  Copy full SHA for f218a38

• feat: Signed mont-reduce

  Tabaie

  committed
  9a4de1e

  Copy full SHA for 9a4de1e

Commits on Nov 19, 2021

• chore: signed/unsigned versions of SOS mont for comparison

  Tabaie

  committed
  e4d1197

  Copy full SHA for e4d1197

• feat: Three ways of dealing with signed numbers in montgomery reduction

  Tabaie

  committed
  89eac26

  Copy full SHA for 89eac26

• style: minor changes

  Tabaie

  committed
  916f502

  Copy full SHA for 916f502

• perf: signed sos ftw

  Tabaie

  committed
  9346b8a

  Copy full SHA for 9346b8a

• style: comments and proofs

  Tabaie

  committed
  d8ffac0

  Copy full SHA for d8ffac0

Commits on Nov 29, 2021

• feat!: Code generated, faulty

  Tabaie

  committed
  ebc5645

  Copy full SHA for ebc5645

• fix: All bn254 tests pass but TestMonReduceNegFixed

  Tabaie

  committed
  278a8f1

  Copy full SHA for 278a8f1

Commits on Nov 30, 2021

• feat: Autogen P20

  Show description for a2ff155
  Tabaie

  committed
  a2ff155

  Copy full SHA for a2ff155

• test: Autogen Montgomery reduction tests

  Tabaie

  committed
  215364b

  Copy full SHA for 215364b

• test: Autogen correction factor checking test

  Tabaie

  committed
  3be03b0

  Copy full SHA for 3be03b0

Commits on Dec 1, 2021

• fix: fix neg template to actually use borrow value

  gbotrel

  committed
  bbb2b9e

  Copy full SHA for bbb2b9e

• chore: Autogen all tests. TODO: bls12-377 fr loops

  Tabaie

  committed
  1ad48ce

  Copy full SHA for 1ad48ce

• style: broke inv

  Tabaie

  committed
  d5d952c

  Copy full SHA for d5d952c

• fix!: Integration test codegen works. Failing edge cases with len(q)

  Tabaie

  committed
  9bf9eb5

  Copy full SHA for 9bf9eb5

Commits on Dec 2, 2021

• fix: unbroke the tests

  Tabaie

  committed
  73050c5

  Copy full SHA for 73050c5

• Merge branch 'style/broke-inv' into improvement/field-inv-pornin20

  Tabaie

  committed
  fa8f2f1

  Copy full SHA for fa8f2f1

Commits on Dec 3, 2021

• style: hardcoded values shall be consts

  Show description for 705662b
  Tabaie

  committed
  705662b

  Copy full SHA for 705662b

• style: Compute number of iterations only in field.go only

  Tabaie

  committed
  586554e

  Copy full SHA for 586554e

• fix: number of iterations corrected. integration tests pass

  Tabaie

  committed
  7658065

  Copy full SHA for 7658065

• feat!: morning snapshot. Issue with neg

  Tabaie

  committed
  3fd1a19

  Copy full SHA for 3fd1a19

Commits on Dec 6, 2021

• fix: Neg passes, lingering issues with test randomizer

  Tabaie

  committed
  2360779

  Copy full SHA for 2360779

• style: all "//" to be followed with a space

  Tabaie

  committed
  85694ad

  Copy full SHA for 85694ad

• chore: mathfmt, change correctionFac from var to consts, cite Pornin

  Tabaie

  committed
  3dafd6a

  Copy full SHA for 3dafd6a

• chore: Not demanding 64bit arch. TODO: Test correctness on one

  Tabaie

  committed
  c6663e9

  Copy full SHA for c6663e9

• perf: Replace mulWRegular with faster branched version

  Tabaie

  committed
  0051bfb

  Copy full SHA for 0051bfb

• test: BenchInverse to call InverseOld

  Tabaie

  committed
  c63f97c

  Copy full SHA for c63f97c

• style: comments

  Tabaie

  committed
  e32238d

  Copy full SHA for e32238d

• style: comments

  Tabaie

  committed
  636c8ec

  Copy full SHA for 636c8ec

• Merge remote-tracking branch 'origin/develop' into improvement/field-inv-pornin20

  Tabaie

  committed
  5d9a7bf

  Copy full SHA for 5d9a7bf

• Merge branch 'improvement/field-inv-pornin20' into perf/compressed-update-factors

  Tabaie

  committed
  1fb780c

  Copy full SHA for 1fb780c

• fix: Update factor negation works

  Tabaie

  committed
  e4f7831

  Copy full SHA for e4f7831

• feat!: Update factor compression works. No speedup? Broke Json conv

  Tabaie

  committed
  47389e4

  Copy full SHA for 47389e4

• perf: Inlined conversion factor manipulation

  Tabaie

  committed
  df96df1

  Copy full SHA for df96df1

• perf: Combined updates factor to be signed, next: fewer helper vars

  Tabaie

  committed
  86e63e1

  Copy full SHA for 86e63e1

• perf: fewer helper variables

  Tabaie

  committed
  c837489

  Copy full SHA for c837489

• style: mathfmt

  Tabaie

  committed
  5363e14

  Copy full SHA for 5363e14

Commits on Dec 7, 2021

• perf: Four update factor vars

  Tabaie

  committed
  550eb2e

  Copy full SHA for 550eb2e

• perf: partial rollback for bn254-fp

  Tabaie

  committed
  98b284f

  Copy full SHA for 98b284f

• fix: semi-compressed bn254/fp

  Tabaie

  committed
  60ffe80

  Copy full SHA for 60ffe80

• chore: generify semicompressed

  Tabaie

  committed
  370c3af

  Copy full SHA for 370c3af

• style: more expressive argument name for approximate

  Tabaie

  committed
  68bdbcd

  Copy full SHA for 68bdbcd

• chore: Take out InverseOld

  Tabaie

  committed
  d4e4e45

  Copy full SHA for d4e4e45

• chore: staticcheck, correct commented formula for outer loop iterations

  Tabaie

  committed
  d29e2a5

  Copy full SHA for d29e2a5

Commits on Dec 8, 2021

• fix: 32bit compatible assertMatch for bn254/fp

  Tabaie

  committed
  3157553

  Copy full SHA for 3157553

• fix: fixed bug for 64b

  Tabaie

  committed
  29bcddc

  Copy full SHA for 29bcddc

• chore: generify 32bit fix

  Tabaie

  committed
  286c036

  Copy full SHA for 286c036

• revert: remove mathfmt (for now)

  Tabaie

  committed
  9d7926b

  Copy full SHA for 9d7926b