Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Decompose #264

Merged
merged 1 commit into from
Nov 15, 2022
Merged

add Decompose #264

merged 1 commit into from
Nov 15, 2022

Conversation

zhiqiangxu
Copy link
Contributor

Moved from Consensys/gnark#398 .

@zhiqiangxu zhiqiangxu mentioned this pull request Nov 15, 2022
Closed
@ThomasPiellard
Copy link
Contributor

Thanks, can you change the branch you want to merge into from master to feat/add_decompose_mimc ? Then I will modify the function checksum in the mimc implems to call Decompose.

@zhiqiangxu zhiqiangxu changed the base branch from master to feat/add_decompose_mimc November 15, 2022 16:57
@zhiqiangxu
Copy link
Contributor Author

Thanks, can you change the branch you want to merge into from master to feat/add_decompose_mimc ? Then I will modify the function checksum in the mimc implems to call Decompose.

Done.

@ThomasPiellard ThomasPiellard merged commit 01e1b3a into Consensys:feat/add_decompose_mimc Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiqiangxu @ThomasPiellard