-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes FromMont
and ToMont
from field.Element
api
#288
Conversation
@@ -9,6 +9,7 @@ import ( | |||
func TestG1IsogenyVectors(t *testing.T) { | |||
t.Parallel() | |||
|
|||
// TODO @gbotrel fix me test vectors shouldn't set words directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, if these come from the standard docs they should be available in decimal or hex form.
Trying to upgrade our version of gnark-crypto from 0.8 to 0.9.
whereas now MultiExpConfig does not have a ScalarsMont argument. I see that the default was set to false in 0.8. Can I just remove that field and everything will work fine? Or will this lead to breaking changes? Disclaimer: I don't know what montgomery form is. |
That was actually an overlook on my sight, pointed by other users in the past; there is actually a subtle breaking change here.. the default is now effectively But callers without an explicit value would have had the default at: |
Awesome thanks! Small note: would have been useful if you guys added a |
See #276