-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf/gkr #319
Conversation
perf: gkr improvements
@@ -44,7 +44,7 @@ type inUseData struct { | |||
|
|||
type Pool struct { | |||
//lock sync.Mutex | |||
inUse map[*fr.Element]inUseData | |||
inUse sync.Map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note in general about the memory pool; impact on benchmarks on my M1 laptop where negligible (vs just calling make([]fr.Element, ..)
)) . If it has no impact on the hpc6a
instance, I'ld rather we remove this, the only piece in our codebase with unsafe
import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its impact will increase the larger the number of instances are. Will check.
No description provided.