Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pedersen_hash added to stark curve #324

Closed
wants to merge 1 commit into from
Closed

feat: pedersen_hash added to stark curve #324

wants to merge 1 commit into from

Conversation

anshulforyou
Copy link
Contributor

Added the pedersen hash to the stark curve ecc family

@yelhousni
Copy link
Collaborator

Thank you @anshulforyou for you contribution! Actually, for other curves, the Pedersen hash we would be interested in would be on the companion twisted Edwards curves (twistededwards package). So either we move your Pedersen hash to the root stark-curve/ in which case the other Pedersen hashes would be in twistededwards/ (as in eddsa) or we move it to fp/ in which case the others would be in fr/ (which is the fp/ of these companion twisted Edwards).
Anyway, let me review your PR and get it merged so that you can guys use it and then we'll figure out for the other curves.

@yelhousni yelhousni self-requested a review February 1, 2023 13:18
yelhousni
yelhousni requested changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can move the pedersen_hash/ to the root dir stark_curve/ for now. The other perf-related changes are optional.

ecc/stark-curve/fr/pedersen_hash/pedersen_hash.go Show resolved Hide resolved
ecc/stark-curve/fr/pedersen_hash/pedersen_hash.go Show resolved Hide resolved
ecc/stark-curve/fr/pedersen_hash/pedersen_hash.go Show resolved Hide resolved
@yelhousni yelhousni mentioned this pull request Feb 3, 2023
Merged
@yelhousni
Copy link
Collaborator

continues in #327

@yelhousni yelhousni closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelhousni yelhousni yelhousni requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshulforyou @yelhousni