Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a proper bash file to run benchmarks #326

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

mmaker
Copy link

@mmaker mmaker commented Feb 2, 2023

No description provided.

@yelhousni
Copy link
Collaborator

yelhousni commented Feb 3, 2023

Not all benchmarks are defined for all curves (e.g. no G2 nor pairing for secp256k1) but it still works. The output when the benchmark is not defined would be something like this:

PASS
ok  	github.com/consensys/gnark-crypto/ecc/secp256k1	0.138s
PASS

So it's up to the python parser to ignore it.

@asn-d6
Copy link

asn-d6 commented Feb 3, 2023

Not all benchmarks are defined for all curves (e.g. no G2 nor pairing for secp256k1) but it still works. The output when the benchmark is not defined would be something like this:

PASS
ok  	github.com/consensys/gnark-crypto/ecc/secp256k1	0.138s
PASS

So it's up to the python parser to ignore it.

ACK. That's fine. We can ignore that.

@yelhousni yelhousni merged commit e22c6fa into Consensys:zkalc Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants