-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make mapToCurve
public to allow for custom cofactor clearing
#372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This PR is against master. In general we base against develop first and then merge whole develop into master. Without knowing the context, was it intentional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tabaie already confirmed that PR is good. Halting only until figuring out which branch to base on.
Oh, sorry, wasn't intentional, do I base against develop then? |
Develop should be good! |
86feb5e
to
2da6b16
Compare
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, good to go!
This PR allow third party software to rely on the
mapToCurve
provided by gnark-crypto independently from the cofactor clearing.