Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate gkr template generation #439

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Aug 29, 2023

Description

Remove duplicate gkr generation calls.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Not tested. There was only duplicate calls to generation.

How has this been benchmarked?

Not benchmarked.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from Tabaie August 29, 2023 06:43
@ivokub ivokub self-assigned this Aug 29, 2023
@Tabaie Tabaie merged commit 82322be into master Nov 6, 2023
8 checks passed
@Tabaie Tabaie deleted the fix/duplicate-gkr-gen branch November 6, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants