-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: GLV exponentiation in GT with large exponents #451
Conversation
Summary✅ Passed: 5883 🚧 Skipped
|
Summary✅ Passed: 5883 🚧 Skipped
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good 👍
The last two commits just fix few typos and some cosmetics:
- merges the new (exp, expGLV) with the old (exp, expGLV and CyclotomicExp) test;
- uses
genA
variable to switchGenE12()
forGenE24()
orGenE6()
when needed; - uses
{{ toUpper .Name}}
for curves' names instead of BN254 in the new test; - manually apply the fix (and test) to BLS24-* and BW6-* as the towers are not auto-generated there.
ops[0].Set(a) | ||
e := s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yelhousni @ThomasPiellard this snippet is weird? didn't review this PR but to me this code is useless.
What does this code do; assign a *big.Int, overwrites it with an object from a pool, and Neg(s) into e, the object of the pool before discarding it.
Description
Type of change
How has this been tested?
Checklist: