Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes #491 #492

Merged
merged 7 commits into from
Mar 19, 2024
Merged

fix: fixes #491 #492

merged 7 commits into from
Mar 19, 2024

Conversation

ThomasPiellard
Copy link
Contributor

Description

Adds a method GenFrStar() in domain.go to get a generator of Fr* (wrongly named "generator of largest two adic subgroup" before").

Fixes # 491

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not sure about the method name, I think it deviates from out current method naming pattern a bit.

internal/generator/fft/template/domain.go.tmpl Outdated Show resolved Hide resolved
internal/generator/fft/template/domain.go.tmpl Outdated Show resolved Hide resolved
internal/generator/fft/template/domain.go.tmpl Outdated Show resolved Hide resolved
@ThomasPiellard ThomasPiellard merged commit 73d5980 into master Mar 19, 2024
7 checks passed
@ThomasPiellard ThomasPiellard deleted the feat/gen_fr_star branch March 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants