Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move test utils package into isolation to avoid every user to import test stuff #500

Merged
merged 1 commit into from
May 4, 2024

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented May 3, 2024

Previous state forced any package that imported utils (meaning a lot...) to import test stuff as side effect, and for example forced binaries building on top of gnark/gnark-crypto to embed testify/...

@gbotrel gbotrel requested review from Tabaie and ivokub May 3, 2024 00:45
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbotrel gbotrel merged commit 1ff1ab8 into master May 4, 2024
7 checks passed
@gbotrel gbotrel deleted the refactor/utils_side_effect branch May 4, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants