Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove E3 Conjugate from BW6 #514

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

yelhousni
Copy link
Collaborator

Description

Conjugate in Fp3 for BW6-761, BW6-756 and BW6-633 are incorrect but they are not used anywhere. This PR removes the corresponding code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Conjugate tests are removed too.

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added the bug Something isn't working label Jun 24, 2024
@yelhousni yelhousni added this to the v0.10.0 milestone Jun 24, 2024
@ThomasPiellard ThomasPiellard merged commit f7d26b6 into master Jul 1, 2024
7 checks passed
@ivokub ivokub deleted the refactor/bw6-conj branch July 1, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants