Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix most typos #1185

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix: fix most typos #1185

merged 3 commits into from
Aug 30, 2024

Conversation

shuriu
Copy link
Contributor

@shuriu shuriu commented Jun 30, 2024 •
edited
Loading

Description

I use some tools to detect the typo. This pr will fix most typos it finds.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub added the typo Fixes typos in comments or documentation label Aug 30, 2024
ivokub
ivokub approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future keep in mind that we code generate some code and the typos should fixed in the documentation. I pushed the corresponding update for now.

@ivokub ivokub changed the base branch from master to fix/typos August 30, 2024 08:29
@ivokub ivokub merged commit 1e1d6b1 into Consensys:fix/typos Aug 30, 2024
2 checks passed
ivokub added a commit that referenced this pull request Aug 30, 2024
@ivokub @bytetigers
@highcloudwind @shuriu @fivecut @Pan-chao
fix: several external typo fixes (#1261)
c59881d 
* refactor: use strings.ReplaceAll (#1257)

* chore: fix some function names (#1240)

Signed-off-by: highcloudwind <highcloud@aliyun.com.>
Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>

* fix: fix most typos (#1185)

* fix: fix most typos

* fix: update template

---------

Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>

* chore: make function comment match function names (#1168)

Signed-off-by: fivecut <fivecut@126.com>

* chore(std): some proofreading (#1001)

* err msg

* emulated field

* bounded

---------

Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>

---------

Signed-off-by: highcloudwind <highcloud@aliyun.com.>
Signed-off-by: fivecut <fivecut@126.com>
Co-authored-by: bytetigers <bytetiger@icloud.com>
Co-authored-by: highcloudwind <highcloud@aliyun.com>
Co-authored-by: shuriu <161208801+shuriu@users.noreply.github.com>
Co-authored-by: fivecut <fivecut@126.com>
Co-authored-by: Pan chao <152830401+Pan-chao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
typo Fixes typos in comments or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuriu @CLAassistant @ivokub