fix: fix slice init length

[cuishuang]

Description

The intention here should be to initialize a slice with a capacity of len(prof.Location) rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Type of change

• Bug fix (non-breaking change which fixes an issue)

How has this been tested?

• Test A
• Test B

How has this been benchmarked?

• Benchmark A, on Macbook pro M1, 32GB RAM
• Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I did not modify files generated from templates
• golangci-lint does not output errors locally
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[CLAassistant]

All committers have signed the CLA.

[ivokub]

Thanks for the PR. Right now it indeed seems that we initialize the nodes differently. I'll further check if we don't somehow assume that first len(prof.Location) values are there for inserting something, but currently it looks like not.

[cuishuang]

Thanks for the PR. Right now it indeed seems that we initialize the nodes differently. I'll further check if we don't somehow assume that first len(prof.Location) values are there for inserting something, but currently it looks like not.

I have searched many Go repositories, and this is a common issue. I am trying to solve it at the Go toolchain level

[ivokub]

Thanks for the PR. Right now it indeed seems that we initialize the nodes differently. I'll further check if we don't somehow assume that first len(prof.Location) values are there for inserting something, but currently it looks like not.

I have searched many Go repositories, and this is a common issue. I am trying to solve it at the Go toolchain level

Interesting! Imo it is a very good find. Indeed we have based our profiling implementation on the Go standard one, but capturing different metrics.

[cuishuang]

Thanks for the PR. Right now it indeed seems that we initialize the nodes differently. I'll further check if we don't somehow assume that first len(prof.Location) values are there for inserting something, but currently it looks like not.

I have searched many Go repositories, and this is a common issue. I am trying to solve it at the Go toolchain level

Interesting! Imo it is a very good find. Indeed we have based our profiling implementation on the Go standard one, but capturing different metrics.

Thank you for your recognition!

I am preparing to add a detection item in go vet to avoid this issue. In the future, it may only be necessary to update the Go version, as there will be relevant detection items in the latest toolchain

[ivokub]

I checked - in gnark this code path is never called and cannot be called without modifying the internal implementation. And even if it is initalized incorrectly, then later in selectNodesForGraph the nil entries are filtered out. But the issue is valid in any case.

Thanks for reporting!

[ivokub]

LGTM!