Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some problematic function names in comment #1334

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

hishope
Copy link
Contributor

@hishope hishope commented Nov 29, 2024

Description

fix some problematic function names in comment

Type of change

  • Docs update

How has this been tested?

  • Test A
  • Test B

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub changed the base branch from master to fix/typos-v0.12 December 4, 2024 00:12
@ivokub ivokub added the typo Fixes typos in comments or documentation label Dec 4, 2024
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution!

@ivokub ivokub merged commit 14c4418 into Consensys:fix/typos-v0.12 Dec 4, 2024
ivokub pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo Fixes typos in comments or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants