Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer): Fix attestation ID search redirection #873

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mo-hak
Copy link

@mo-hak mo-hak commented Jan 14, 2025

What does this PR do?

This PR implements automatic navigation from the search page when attestation-specific results are found. When the search results only contain attestations (no modules, portals, or schemas), the user is automatically redirected to:

  • The attestation details page if the search term matches an attestation ID
  • The subject's attestations page if the search term matches other attestation criteria

Related ticket

Fixes #872

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • [✕ ] Unit tests for any smart contract change
  • [ ✕] Contracts and functions are documented
    Screenshot (62)
    Screenshot (63)

Copy link

cla-assistant bot commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 14, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alainncls
Copy link
Collaborator

alainncls commented Jan 15, 2025

Hey @mo-hak thanks for the fix, it works smoothly!
We'd just need you to sign the CLA via the link in the comment above and we'll be able to merge and deploy the fix! 🙂
Also there seems to be a lint issue, can you check it locally via pnpm run lint? 🙏

@mo-hak mo-hak requested a review from a team as a code owner January 15, 2025 18:36
@mo-hak
Copy link
Author

mo-hak commented Jan 15, 2025

@alainncls signed cla and fixed lint errors, please check if any further changes required

@mo-hak
Copy link
Author

mo-hak commented Jan 18, 2025

@alainncls signed cla and fixed lint errors, please check if any further changes requir

hey @alainncls ! Is there any issue in the PR ? Let me know I will fix it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Attestation ID search brings you to the wrong page on the explorer
2 participants