Feat: Dummy PI Circuit #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
============================================
+ Coverage 70.19% 70.28% +0.09%
- Complexity 1080 1081 +1
============================================
Files 305 305
Lines 12419 12419
Branches 1180 1180
============================================
+ Hits 8717 8729 +12
+ Misses 3206 3196 -10
+ Partials 496 494 -2
*This pull request uses carry forward flags. Click here to find out more. |
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Tabaie
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Tabaie
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Tabaie
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dummy circuit for public input interconnection. As with other circuits, the
devmode in the config will result in creating/proving with this small dummy circuit andfullwill do the same with the full circuit.A third mode
lightis available for a real circuit that doesn't prove/check the correctness of its Keccak256 hashes.Tests for the aggregation circuit are also fixed and refactored.
Also, the tests revealed that complete arithmetic is sometimes necessary for the verification of the PI circuit. The option is added back in.