Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'pragma solidity' parsing #1887

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

gsalzer
Copy link
Contributor

@gsalzer gsalzer commented Oct 30, 2024

remove comments and strings before searching for a line containing 'pragma solidity'

remove comments and strings before searching for a line containing 'pragma solidity'
@gsalzer
Copy link
Contributor Author

gsalzer commented Oct 30, 2024

The patch tries to be minimally invasive; you may want to integrate it better. The comment citing the source can be removed (no need to give credits), it is just to inspire trust (?) that the code works since we used it for processing source codes in one of our studies.

@norhh
Copy link
Collaborator

norhh commented Nov 5, 2024

For some reason, I’ve lost access to the CircleCI pipeline results over the past month. @psantos-consensys, could you look into the cause of CircleCI’s failure? Additionally, could you change the permissions to view Mythril’s CircleCI results? Since Mythril is open-source, these results should ideally be public as they were previously.

@gsalzer
Copy link
Contributor Author

gsalzer commented Dec 17, 2024

@norhh @psantos-consensys Any chance that something is going to happen in the near future? I'm fine with the pull request being rejected but this CircleCI pipeline issue occurring with every pull request now seems to be unhealthy.

@norhh
Copy link
Collaborator

norhh commented Dec 17, 2024

I don't know when it will be fixed/visible. I've asked someone to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants