Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply upstream clef bug fixes and add clef documentation #1009

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Apply upstream clef bug fixes and add clef documentation #1009

merged 4 commits into from
Jun 15, 2020

Conversation

chris-j-h
Copy link
Collaborator

The cherry-picked commits from upstream go-ethereum fix the following bugs when running geth with the --signer flag:

  • "unknown account" error unless eth_accounts is called first
  • eth_sign returns incorrect signature

This PR also adds documentation outlining what clef is and how it is used, with details of the quorum-specific changes made

holiman and others added 4 commits June 3, 2020 17:21
@holiman @chris-j-h
accounts/external: fill account-cache if that hasn't already been don…
9536954 
…e, fixes #20995 (#20998)

(cherry picked from commit d2d3166)
@holiman @chris-j-h
accounts/external: convert signature v value to 0/1 (#20997)
946bf3a 
This fixes an issue with clef, which already transforms the signature
to use the legacy 27/28 encoding.

Fixes #20994

(cherry picked from commit 510b6f9)
@chris-j-h
Add more clef documentation: what it is, quorum changes, how to use
cd2b3b6
@jpmsam
Merge branch 'master' into clef-bugfixes-upstream-cherrypick
502eb51
@jpmsam
Copy link
Contributor

jpmsam commented Jun 14, 2020

Picked from geth PRs 20998 and 20997

@jpmsam jpmsam merged commit 072e93a into Consensys:master Jun 15, 2020
@chris-j-h chris-j-h deleted the clef-bugfixes-upstream-cherrypick branch June 16, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmsam jpmsam jpmsam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-j-h @jpmsam @holiman