Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interposed functions should be internal not private #257

Closed
cd1m0 opened this issue Jan 31, 2024 · 1 comment
Closed

Interposed functions should be internal not private #257

cd1m0 opened this issue Jan 31, 2024 · 1 comment
Assignees

Comments

@cd1m0
Copy link
Collaborator

cd1m0 commented Jan 31, 2024

Given this sample:

contract Base {
   /// #if_succeeds true;
   function foo() internal returns (uint) {}
}

/// #invariant foo() == 1;
contract Child is Base {
}

The foo function in the base will be renamed to __original_Base_foo and made private.
However in the instrumentation of Child we will try to use the interposed function (__original_Base_foo) which is no longer accessible in Child since its now private.

To fix this we should make interposed functions internal.

@cd1m0 cd1m0 self-assigned this Jan 31, 2024
cd1m0 added a commit that referenced this issue Jan 31, 2024
cd1m0 added a commit that referenced this issue Feb 1, 2024
* Fix for #257; Add small ERC1155 macro

* Fix failing tests
@blitz-1306
Copy link
Contributor

This is addressed by #258. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants