Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scribble should emit try/require annotations before all other when instrumenting #272

Closed
cd1m0 opened this issue Jun 24, 2024 · 1 comment
Assignees

Comments

@cd1m0
Copy link
Collaborator

cd1m0 commented Jun 24, 2024

Given this sample:

/// #try foo;
/// #if_succeeds old(bar);
function moo() {
 ....
}

scribble currently emits the code for old(bar) before the code for #try foo. This can sometimes be a problem, when the fuzzer is having trouble getting past some part of bar, and needs the annotation for foo to figure things out.

Instead we should make sure to emit the code for all #try and #require annotations first, to make sure they first help the fuzzer explore the space, before it hits the actual annotation code.

@cd1m0 cd1m0 self-assigned this Jun 24, 2024
cd1m0 added a commit that referenced this issue Jun 24, 2024
@cd1m0 cd1m0 mentioned this issue Jun 24, 2024
cd1m0 added a commit that referenced this issue Jun 24, 2024
@cd1m0
Copy link
Collaborator Author

cd1m0 commented Jun 24, 2024

Fixed in #274.

@cd1m0 cd1m0 closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant