Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition subcommand: Report failures to parse SSZ in a more friendly manner #1690

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

ajsutton
Copy link
Contributor

PR Description

The input data for pre-state and beacon blocks read while executing the transition subcommand may be invalid SSZ. Previously the resulting exception would just be printed to the console, this tidies up the output to make it clear that this is a user error, not an unexpected processing error.

Fixed Issue(s)

fixes #1675
fixes #1677

Copy link
Contributor

@cemozerr cemozerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit 7445288 into Consensys:master Apr 29, 2020
@ajsutton ajsutton deleted the transition-ssz-errors branch April 29, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants