Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom options renderer to add mixin headings instead of arg groups #6556

Merged
merged 7 commits into from
Dec 6, 2022

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Dec 6, 2022

PR Description

Switch back to using @Mixin to include options rather than everything using @ArgGroup and then use a custom options renderer to add in the headings.

Using arg groups affects how validation works which caused some weird situations, including potentially ignoring options.

Fixed Issue(s)

fixes #6146

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton enabled auto-merge (squash) December 6, 2022 04:01
@ajsutton ajsutton merged commit afdc8fb into Consensys:master Dec 6, 2022
@ajsutton ajsutton deleted the custom-help-format branch December 6, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting --validators-keystore-locking-enabled=false has Teku complain about --ee-endpoint
2 participants