Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disable auto discovery #477

Merged
merged 7 commits into from Sep 26, 2018
Merged

Feature/disable auto discovery #477

merged 7 commits into from Sep 26, 2018

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Sep 26, 2018

Prevent new peers/parties being added if auto discovery is disabled.

particularly when it needs to updating. Add error handing so an exception 
is raised when an attempt to update party info is made when auto discovery 
is disabled.
@codecov-io
Copy link

codecov-io commented Sep 26, 2018

Codecov Report

Merging #477 into master will decrease coverage by 0.02%.
The diff coverage is 98.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #477      +/-   ##
============================================
- Coverage      99.7%   99.68%   -0.03%     
- Complexity     1146     1156      +10     
============================================
  Files           182      185       +3     
  Lines          3753     3783      +30     
  Branches        196      198       +2     
============================================
+ Hits           3742     3771      +29     
- Partials         11       12       +1
Impacted Files Coverage Δ Complexity Δ
...m/quorum/tessera/config/builder/ConfigBuilder.java 100% <100%> (ø) 38 <0> (ø) ⬇️
.../quorum/tessera/core/config/ConfigServiceImpl.java 100% <100%> (ø) 2 <2> (?)
...a/com/quorum/tessera/config/JaxbConfigFactory.java 100% <100%> (ø) 13 <4> (ø) ⬇️
...m/tessera/node/AutoDiscoveryDisabledException.java 100% <100%> (ø) 1 <1> (?)
...rc/main/java/com/quorum/tessera/config/Config.java 100% <100%> (ø) 11 <3> (+1) ⬆️
...xception/AutoDiscoveryDisabledExceptionMapper.java 100% <100%> (ø) 2 <2> (?)
...uorum/tessera/api/grpc/StreamObserverTemplate.java 100% <100%> (ø) 3 <0> (ø) ⬇️
.../com/quorum/tessera/node/PartyInfoServiceImpl.java 97.77% <92.85%> (-2.23%) 12 <5> (+4)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3c38b...27a59bc. Read the comment docs.

@Krish1979 Krish1979 self-assigned this Sep 26, 2018
@Krish1979 Krish1979 merged commit 242c7a0 into Consensys:master Sep 26, 2018
@melowe melowe deleted the feature/disable-auto-discovery branch October 1, 2018 09:55
@prd-fox prd-fox added enhancement Non-user code enhancements 0.7 labels Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants